Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 10693047: Report type warning on assigning to some types of elements (Closed)

Created:
8 years, 5 months ago by zundel
Modified:
8 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Brian Wilkerson
Visibility:
Public.

Description

Report type warning on assigning to some types of elements For elements that are instance members, we want to emit a type warning as opposed to a hard compile-time error. Issue 3662 : http://code.google.com/p/dart/issues/detail?id=3662 Committed: https://code.google.com/p/dart/source/detail?r=9255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -3 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 4 chunks +27 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 2 chunks +58 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 5 months ago (2012-06-29 17:07:51 UTC) #1
scheglov
8 years, 5 months ago (2012-06-29 17:10:30 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698