Issue 10693028: Avoid generating '>>> 0' for bitops for which the result is only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10693028: Avoid generating '>>> 0' for bitops for which the result is only (Closed)

Created:
8 years, 5 months ago by Mads Ager (google)

Modified:
8 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid generating '>>> 0' for bitops for which the result is only used as input to other bitops. Additionally, recognize HBitAnd with constants that will always produce positive results. R=floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9234

Patch Set 1 #

Patch Set 2 : Change name of helper #

Total comments: 2

Patch Set 3 : Address comments. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -2 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View	1 2	3 chunks	+33 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! https://chromiumcodereview.appspot.com/10693028/diff/3001/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10693028/diff/3001/lib/compiler/implementation/ssa/codegen.dart#newcode204 lib/compiler/implementation/ssa/codegen.dart:204: if (value >= 0 && value < Math.pow(2, ...

8 years, 5 months ago (2012-06-28 22:57:18 UTC) #2

Mads Ager (google)

8 years, 5 months ago (2012-06-29 00:03:23 UTC) #3

https://chromiumcodereview.appspot.com/10693028/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10693028/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:204: if (value >= 0 && value <
Math.pow(2, 31)) {
On 2012/06/28 22:57:18, floitsch wrote:
> (1 << 31) would be a compile time constant. Math.pow isn't.
> Not a strong preference, though.

Done.

Expand Messages | Collapse Messages