Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10692109: Support parsing of constructs like T[]?. (Closed)

Created:
8 years, 5 months ago by Anton Muhin
Modified:
8 years, 5 months ago
Reviewers:
podivilov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support parsing of constructs like T[]?. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=9442

Patch Set 1 #

Total comments: 5

Patch Set 2 : Next #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M lib/dom/scripts/idlparser.py View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
8 years, 5 months ago (2012-07-06 13:58:51 UTC) #1
podivilov
https://chromiumcodereview.appspot.com/10692109/diff/1/lib/dom/scripts/idlparser.py File lib/dom/scripts/idlparser.py (right): https://chromiumcodereview.appspot.com/10692109/diff/1/lib/dom/scripts/idlparser.py#newcode291 lib/dom/scripts/idlparser.py:291: [AnyType, MAYBE([ArrayModifiers, MAYBE(Nullable)])], Why special case for AnyType? https://chromiumcodereview.appspot.com/10692109/diff/1/lib/dom/scripts/idlparser.py#newcode295 ...
8 years, 5 months ago (2012-07-06 15:15:28 UTC) #2
Anton Muhin
https://chromiumcodereview.appspot.com/10692109/diff/1/lib/dom/scripts/idlparser.py File lib/dom/scripts/idlparser.py (right): https://chromiumcodereview.appspot.com/10692109/diff/1/lib/dom/scripts/idlparser.py#newcode291 lib/dom/scripts/idlparser.py:291: [AnyType, MAYBE([ArrayModifiers, MAYBE(Nullable)])], On 2012/07/06 15:15:28, podivilov wrote: > ...
8 years, 5 months ago (2012-07-06 15:16:44 UTC) #3
podivilov
https://chromiumcodereview.appspot.com/10692109/diff/1/lib/dom/scripts/idlparser.py File lib/dom/scripts/idlparser.py (right): https://chromiumcodereview.appspot.com/10692109/diff/1/lib/dom/scripts/idlparser.py#newcode291 lib/dom/scripts/idlparser.py:291: [AnyType, MAYBE([ArrayModifiers, MAYBE(Nullable)])], On 2012/07/06 15:16:44, antonmuhin wrote: > ...
8 years, 5 months ago (2012-07-06 15:24:48 UTC) #4
podivilov
8 years, 5 months ago (2012-07-06 15:56:40 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698