Issue 10692087: Reapply change to update dart2js operator equals semantics to follow

Issue 10692087: Reapply change to update dart2js operator equals semantics to follow (Closed)

Created:
8 years, 5 months ago by Mads Ager (google)

Modified:
8 years, 4 months ago

Reviewers:
floitsch, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply change to update dart2js operator equals semantics to follow the latest spec. Changes since the version that was reverted are in patch set 2: 1. Fix one remaining dart2js test that relied on the old operator== behavior. 2. Fix type intersection operation to actually take null into account. Because of bounded types they should always use canBeNull. R=floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9396

Patch Set 1 #

Patch Set 2 : Fix type intersection issue #

Patch Set 3 : Whoops, fix eqB to use === true #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -88 lines)			Patch
M	lib/compiler/implementation/lib/js_helper.dart	View	1 2	3 chunks	+4 lines, -26 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	lib/compiler/implementation/ssa/types.dart	View	1	6 chunks	+7 lines, -8 lines	0 comments	Download
M	lib/unittest/core_matchers.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-leg.status	View		1 chunk	+4 lines, -0 lines	2 comments	Download
M	tests/compiler/dart2js/boolified_operator_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/constant_folding_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js_extra/operator_equals_test.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/operator5_test.dart	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://chromiumcodereview.appspot.com/10692087/diff/11001/tests/co19/co19-leg.status File tests/co19/co19-leg.status (right): https://chromiumcodereview.appspot.com/10692087/diff/11001/tests/co19/co19-leg.status#newcode350 tests/co19/co19-leg.status:350: LibTest/core/Expect/equals_A01_t03: Fail # not following the spec and expects ...

8 years, 4 months ago (2012-08-17 20:45:50 UTC) #3

Mads Ager (google)

8 years, 4 months ago (2012-08-20 07:54:33 UTC) #4

https://chromiumcodereview.appspot.com/10692087/diff/11001/tests/co19/co19-le...
File tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/10692087/diff/11001/tests/co19/co19-le...
tests/co19/co19-leg.status:350: LibTest/core/Expect/equals_A01_t03: Fail # not
following the spec and expects the user-defined equality operator
On 2012/08/17 20:45:50, srdjan wrote:
> Please file co19 issues instead of adding a comment, Thanks!

I did and it has already been marked as fixed.
https://code.google.com/p/co19/issues/detail?id=156

Expand Messages | Collapse Messages