Issue 10692072: Fix a bug in SSA renaming introduced when using the RemoveFromGraph helper for removing instruction…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10692072: Fix a bug in SSA renaming introduced when using the RemoveFromGraph helper for removing instruction… (Closed)

Created:
8 years, 5 months ago by Florian Schneider

Modified:
8 years, 5 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Fix a bug in SSA renaming introduced when using the RemoveFromGraph helper for removing instructions. The helper function RemoveFromGraph resets previous and next instruction pointers to NULL when deleting an instruction. I changed it to return the successor of the removed instruction so that the function is more convenient to use while iterating over the list of instructions. Committed: https://code.google.com/p/dart/source/detail?r=9332

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -9 lines)			Patch
M	vm/flow_graph_builder.cc	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	vm/intermediate_language.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	vm/intermediate_language.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages