Move function serialization to sync ports.

Move function serialization to sync ports.

For now only dart to JS serialization.

R=sammccall@google.com,vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=10750

[Anton Muhin, 2012-07-11 20:03:27]

Vijay, Kasper, a bit of context.

Sam and me discussed it on the hackathon and we hope we may have backend (DartVM
vs. dart2js) specific implementation of function serialization which will solve
the issues with GC and alike.

For example, in dart2js case we can probably pass closures just by reference,
w/o any additional serialization (omitting one technical issue).

So this is first, leaking implementation of mechanism which should allow us to
clean higher level implementations.

But most importantly we're looking for feedback from you if it's a good idea to
pass functions around.

The hope is function passing fits sync ports semantics perfectly.

[vsm, 2012-08-10 00:18:50]

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js#newcode92
client/dart.js:92: case 'funcref': return deserializeFunction(x);
How about a more descriptive name?  E.g., 'function-proxy'.

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js#newcode138
client/dart.js:138: // Number of arguments is not used as as of now
"as as" -> as

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js#newcode231
client/dart.js:231: return sendPort.callSync([ref,
Array.prototype.slice.call(arguments)]);
Don't the arguments and return value need to be serialized and deserialized?

[Anton Muhin, 2012-08-14 16:42:38]

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js#newcode92
client/dart.js:92: case 'funcref': return deserializeFunction(x);
On 2012/08/10 00:18:50, vsm wrote:
> How about a more descriptive name?  E.g., 'function-proxy'.

I can definitely do it, but I wished to minimize the length of the tag to reduce
size of data to pass.

But if you think we'd better start with more descriptive tags and optimize for
size later, I'll rename.

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js#newcode138
client/dart.js:138: // Number of arguments is not used as as of now
On 2012/08/10 00:18:50, vsm wrote:
> "as as" -> as

Done.

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js#newcode231
client/dart.js:231: return sendPort.callSync([ref,
Array.prototype.slice.call(arguments)]);
I don't remember all the details, but won't callSync take care of
serialization/deserialization?

On 2012/08/10 00:18:50, vsm wrote:
> Don't the arguments and return value need to be serialized and deserialized?

[vsm, 2012-08-15 15:35:36]

lgtm

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js#newcode92
client/dart.js:92: case 'funcref': return deserializeFunction(x);
It's fine for now.

On 2012/08/14 16:42:38, Anton Muhin wrote:
> On 2012/08/10 00:18:50, vsm wrote:
> > How about a more descriptive name?  E.g., 'function-proxy'.
> 
> I can definitely do it, but I wished to minimize the length of the tag to
reduce
> size of data to pass.
> 
> But if you think we'd better start with more descriptive tags and optimize for
> size later, I'll rename.

https://chromiumcodereview.appspot.com/10690142/diff/1/client/dart.js#newcode231
client/dart.js:231: return sendPort.callSync([ref,
Array.prototype.slice.call(arguments)]);
Yes, I think you're correct.

On 2012/08/14 16:42:38, Anton Muhin wrote:
> I don't remember all the details, but won't callSync take care of
> serialization/deserialization?
> 
> On 2012/08/10 00:18:50, vsm wrote:
> > Don't the arguments and return value need to be serialized and deserialized?
>