Issue 10690127: Add support to the version solver for sources that only have a single version per package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10690127: Add support to the version solver for sources that only have a single version per package. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support to the version solver for sources that only have a single version per package. Committed: https://code.google.com/p/dart/source/detail?r=9567

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -11 lines)			Patch
M	utils/pub/root_source.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	utils/pub/sdk_source.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	utils/pub/source.dart	View	1 chunk	+12 lines, -5 lines	0 comments	Download
M	utils/tests/pub/version_solver_test.dart	View	6 chunks	+54 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://chromiumcodereview.appspot.com/10690127/diff/1/utils/tests/pub/version_solver_test.dart File utils/tests/pub/version_solver_test.dart (right): https://chromiumcodereview.appspot.com/10690127/diff/1/utils/tests/pub/version_solver_test.dart#newcode121 utils/tests/pub/version_solver_test.dart:121: 'foo 1.2.3 from versionless': { 'bar': '>=1.0.0' }, ...

8 years, 5 months ago (2012-07-11 16:55:12 UTC) #2

nweiz

8 years, 5 months ago (2012-07-11 19:11:37 UTC) #3

https://chromiumcodereview.appspot.com/10690127/diff/1/utils/tests/pub/versio...
File utils/tests/pub/version_solver_test.dart (right):

https://chromiumcodereview.appspot.com/10690127/diff/1/utils/tests/pub/versio...
utils/tests/pub/version_solver_test.dart:121: 'foo 1.2.3 from versionless': {
'bar': '>=1.0.0' },
On 2012/07/11 16:55:13, Bob Nystrom wrote:
> Can you split this map onto the next line like the other tests?

Done.

Expand Messages | Collapse Messages