Error produced for missing var, final, const or type on field declarations.

Error produced for missing var, final, const or type on field declarations.


BUG=2997
TEST=tests/language/field_decl_missing_var_type_test

Committed: https://code.google.com/p/dart/source/detail?r=9585

[Lasse Reichstein Nielsen, 2012-07-09 11:49:42]

lgtm

https://chromiumcodereview.appspot.com/10690106/diff/1/tests/co19/co19-leg.st...
File tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/10690106/diff/1/tests/co19/co19-leg.st...
tests/co19/co19-leg.status:521:
#Language/07_Classes/5_Constructors/1_Generative_Constructors_A01_t02: Fail, OK
# @compile-error
Remove the line instead of commenting it out.
The test is marked as "Fail, OK", so we presumably we don't, currently, consider
it a priority to fix it. So, why fix it now?

[Johnni Winther, 2012-07-12 09:22:28]

https://chromiumcodereview.appspot.com/10690106/diff/1/tests/co19/co19-leg.st...
File tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/10690106/diff/1/tests/co19/co19-leg.st...
tests/co19/co19-leg.status:521:
#Language/07_Classes/5_Constructors/1_Generative_Constructors_A01_t02: Fail, OK
# @compile-error
On 2012/07/09 11:49:42, Lasse Reichstein Nielsen wrote:
> Remove the line instead of commenting it out.
> The test is marked as "Fail, OK", so we presumably we don't, currently,
consider
> it a priority to fix it. So, why fix it now?

Done.

[ahe, 2012-08-02 19:40:24]

Hi Johnni,

Thank you for reducing my critical bug count!

I have reopened the bug so we don't forget the change I suggest, but now it is a
low priority thing.

Cheers,
Peter

https://chromiumcodereview.appspot.com/10690106/diff/4002/lib/compiler/implem...
File lib/compiler/implementation/scanner/listener.dart (right):

https://chromiumcodereview.appspot.com/10690106/diff/4002/lib/compiler/implem...
lib/compiler/implementation/scanner/listener.dart:1533: (p) =>
p.parseVariablesDeclaration(beginToken));
I think we should rework this change to a "recoverable" error generated by the
parser.