Issue 10690052: added shadow dom layout test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10690052: added shadow dom layout test (Closed)

Created:
8 years, 5 months ago by samhop

Modified:
8 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

added shadow dom layout test BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9263

Patch Set 2 : addressed sigmund's comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
M	tests/html/html.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/html/shadow_dom_layout_test.dart	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
A	tests/html/shadow_dom_layout_test.txt	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://chromiumcodereview.appspot.com/10690052/diff/1/tests/html/shadow_dom_layout_test.dart File tests/html/shadow_dom_layout_test.dart (right): https://chromiumcodereview.appspot.com/10690052/diff/1/tests/html/shadow_dom_layout_test.dart#newcode23 tests/html/shadow_dom_layout_test.dart:23: var sr = new ShadowRoot(div); following jacob's comment ...

8 years, 5 months ago (2012-06-29 20:20:38 UTC) #2

samhop

8 years, 5 months ago (2012-06-29 20:25:12 UTC) #3

fixed and committed

https://chromiumcodereview.appspot.com/10690052/diff/1/tests/html/shadow_dom_...
File tests/html/shadow_dom_layout_test.dart (right):

https://chromiumcodereview.appspot.com/10690052/diff/1/tests/html/shadow_dom_...
tests/html/shadow_dom_layout_test.dart:23: var sr = new ShadowRoot(div);
On 2012/06/29 20:20:38, sigmund wrote:
> following jacob's comment from the other CL, maybe sRoot or root would be more
> descriptive here.

Done.

https://chromiumcodereview.appspot.com/10690052/diff/1/tests/html/shadow_dom_...
tests/html/shadow_dom_layout_test.dart:27: div.nodes.add(bluebox);
On 2012/06/29 20:20:38, sigmund wrote:
> maybe add an empty line above this to see the divide between shadow root vs
> shadow host

Done.

Expand Messages | Collapse Messages

Issue 10690052: added shadow dom layout test (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed sigmund's comments #

Messages