Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 10690039: Suppress printing while testing. (Closed)

Created:
8 years, 5 months ago by Anton Muhin
Modified:
8 years, 5 months ago
Reviewers:
podivilov, ngeoffray
CC:
reviews_dartlang.org, Emily Fortuna, ngeoffray, vsm
Visibility:
Public.

Description

Suppress printing while testing. I suspect that's the reason why test sometimes times out under DRT. R=podivilov@chromium.org BUG=2667, 3834 Committed: https://code.google.com/p/dart/source/detail?r=9245

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tests/corelib/corelib.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/corelib/sort_helper.dart View 1 1 chunk +1 line, -0 lines 4 comments Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
8 years, 5 months ago (2012-06-29 12:00:37 UTC) #1
ngeoffray
https://chromiumcodereview.appspot.com/10690039/diff/2001/tests/corelib/sort_helper.dart File tests/corelib/sort_helper.dart (right): https://chromiumcodereview.appspot.com/10690039/diff/2001/tests/corelib/sort_helper.dart#newcode14 tests/corelib/sort_helper.dart:14: void printList(List a) { Why don't you just remove ...
8 years, 5 months ago (2012-07-11 11:48:49 UTC) #2
Anton Muhin
https://chromiumcodereview.appspot.com/10690039/diff/2001/tests/corelib/sort_helper.dart File tests/corelib/sort_helper.dart (right): https://chromiumcodereview.appspot.com/10690039/diff/2001/tests/corelib/sort_helper.dart#newcode14 tests/corelib/sort_helper.dart:14: void printList(List a) { On 2012/07/11 11:48:49, ngeoffray wrote: ...
8 years, 5 months ago (2012-07-11 11:50:33 UTC) #3
ngeoffray
https://chromiumcodereview.appspot.com/10690039/diff/2001/tests/corelib/sort_helper.dart File tests/corelib/sort_helper.dart (right): https://chromiumcodereview.appspot.com/10690039/diff/2001/tests/corelib/sort_helper.dart#newcode14 tests/corelib/sort_helper.dart:14: void printList(List a) { On 2012/07/11 11:50:34, antonmuhin wrote: ...
8 years, 5 months ago (2012-07-11 11:53:33 UTC) #4
Anton Muhin
8 years, 5 months ago (2012-07-11 11:55:48 UTC) #5
https://chromiumcodereview.appspot.com/10690039/diff/2001/tests/corelib/sort_...
File tests/corelib/sort_helper.dart (right):

https://chromiumcodereview.appspot.com/10690039/diff/2001/tests/corelib/sort_...
tests/corelib/sort_helper.dart:14: void printList(List a) {
np, sending you a CL in a couple of mins.

On 2012/07/11 11:53:33, ngeoffray wrote:
> On 2012/07/11 11:50:34, antonmuhin wrote:
> > On 2012/07/11 11:48:49, ngeoffray wrote:
> > > Why don't you just remove the calls to printList and remove printList?
> > 
> > I didn't add them, so I didn't want to remove them :)
> > 
> > Alas, I wasn't able to recover the story of the file, so I just wild-guessed
> you
> > might have been the original author of this test.
> 
> I think either me or Florian :) In any case, I prefer removing it than having
> the if (true)

Powered by Google App Engine
This is Rietveld 408576698