Issue 10689150: Add registerPort / lookupPort to generated interfaces with documentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10689150: Add registerPort / lookupPort to generated interfaces with documentation (Closed)

Created:
8 years, 5 months ago by vsm

Modified:
8 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add registerPort / lookupPort to generated interfaces with documentation Note, the implementations are already there in Dartium and Dart2JS. This will make the APIs show up in the Editor and dartdoc. Committed: https://code.google.com/p/dart/source/detail?r=9537

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -0 lines)			Patch
M	lib/dom/templates/html/interface/interface_Window.darttemplate	View	1 chunk	+13 lines, -0 lines	2 comments	Download
M	lib/html/dartium/html_dartium.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://chromiumcodereview.appspot.com/10689150/diff/1/lib/dom/templates/html/interface/interface_Window.darttemplate File lib/dom/templates/html/interface/interface_Window.darttemplate (right): https://chromiumcodereview.appspot.com/10689150/diff/1/lib/dom/templates/html/interface/interface_Window.darttemplate#newcode15 lib/dom/templates/html/interface/interface_Window.darttemplate:15: void registerPort(String name, SendPortSync port); should this be ...

8 years, 5 months ago (2012-07-10 23:50:41 UTC) #2

vsm

8 years, 5 months ago (2012-07-10 23:53:24 UTC) #3

thanks!

https://chromiumcodereview.appspot.com/10689150/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/interface/interface_Window.darttemplate (right):

https://chromiumcodereview.appspot.com/10689150/diff/1/lib/dom/templates/html...
lib/dom/templates/html/interface/interface_Window.darttemplate:15: void
registerPort(String name, SendPortSync port);
We do want to allow SendPort (i.e., the async one) at some point.  Not sure
whether to just have one register function (with a var or to be determined
common base type param) or to break it in two.

On 2012/07/10 23:50:41, sigmund wrote:
> should this be registerSyncPort? (do we expect to later have a
registerAsyncPort
> as well?)

Expand Messages | Collapse Messages