CallMatchers can now be null, or take null for a method name. This might be

CallMatchers can now be null, or take null for a method name. This might be
useful if we want to do things like find all method calls that returned a 
certain value.
Committed: https://code.google.com/p/dart/source/detail?r=9570

[gram, 2012-07-10 23:22:30]

Small change; there seems no good reason not to allow this and there may be
cases when it is useful. It may also allow us to make Mock.log private in future
(as you can just use Mock.getLogs() now to get copy of all the logs); I didn't
go that far though.

[Siggi Cherem (dart-lang), 2012-07-10 23:38:28]

http://codereview.chromium.org/10689148/diff/1/tests/lib/unittest/unittest_te...
File tests/lib/unittest/unittest_test.dart (right):

http://codereview.chromium.org/10689148/diff/1/tests/lib/unittest/unittest_te...
tests/lib/unittest/unittest_test.dart:244: m.when(callsTo(null,
1)).alwaysReturn(2);
another option is to pass a regex, rather than a null value. For instance:
callsTo("*", 1).alwaysReturn(2)
callsTo("foo*", 1).alwaysReturn(2)

What do you think?

[gram, 2012-07-11 18:56:08]

PTAL. The mock name and call matcher can both use matchers now. This does lead
to a little bit of weirdness when printing the match filter name (things like
<null>.'foo'()) but that is to be expected I guess.

[Siggi Cherem (dart-lang), 2012-07-11 19:21:38]

lgtm (with small comments below)

http://chromiumcodereview.appspot.com/10689148/diff/5001/tests/lib/unittest/u...
File tests/lib/unittest/unittest_test.dart (right):

http://chromiumcodereview.appspot.com/10689148/diff/5001/tests/lib/unittest/u...
tests/lib/unittest/unittest_test.dart:340: 'mock test 10 (RegExp
CallMatcher)Good::'
Do you need the ::?

http://chromiumcodereview.appspot.com/10689148/diff/5001/tests/lib/unittest/u...
tests/lib/unittest/unittest_test.dart:342: message:'Caught Method names must
start with lower case')
can you include in the error the actual method name so that we see it here
(otherwise I can't tell that the status string has the exception from the right
test case).

[Siggi Cherem (dart-lang), 2012-07-11 19:22:16]

http://chromiumcodereview.appspot.com/10689148/diff/5001/tests/lib/unittest/u...
File tests/lib/unittest/unittest_test.dart (right):

http://chromiumcodereview.appspot.com/10689148/diff/5001/tests/lib/unittest/u...
tests/lib/unittest/unittest_test.dart:340: 'mock test 10 (RegExp
CallMatcher)Good::'
On 2012/07/11 19:21:38, sigmund wrote:
> Do you need the ::?

never mind, I just realized that these are 2 strings concacenated together.

[gram, 2012-07-11 19:40:10]

I split the last test into two to make it clearer.

http://chromiumcodereview.appspot.com/10689148/diff/5001/tests/lib/unittest/u...
File tests/lib/unittest/unittest_test.dart (right):

http://chromiumcodereview.appspot.com/10689148/diff/5001/tests/lib/unittest/u...
tests/lib/unittest/unittest_test.dart:342: message:'Caught Method names must
start with lower case')
On 2012/07/11 19:21:38, sigmund wrote:
> can you include in the error the actual method name so that we see it here
> (otherwise I can't tell that the status string has the exception from the
right
> test case).

I don't think the test framework provides that info. What I can do is split it
up into two separate uber-tests.

[Siggi Cherem (dart-lang), 2012-07-11 19:47:24]

On 2012/07/11 19:40:10, gram wrote:
> I split the last test into two to make it clearer.
> 
>
http://chromiumcodereview.appspot.com/10689148/diff/5001/tests/lib/unittest/u...
> File tests/lib/unittest/unittest_test.dart (right):
> 
>
http://chromiumcodereview.appspot.com/10689148/diff/5001/tests/lib/unittest/u...
> tests/lib/unittest/unittest_test.dart:342: message:'Caught Method names must
> start with lower case')
> On 2012/07/11 19:21:38, sigmund wrote:
> > can you include in the error the actual method name so that we see it here
> > (otherwise I can't tell that the status string has the exception from the
> right
> > test case).
> 
> I don't think the test framework provides that info. What I can do is split it
> up into two separate uber-tests.

I was just thinking that you can make the exception message more precise in your
test, so that it will be easy to recognize here, that's all.

[Siggi Cherem (dart-lang), 2012-07-11 19:47:34]

lgtm