Add test for garbage collected window event listeners issue.

Add test for garbage collected window event listeners issue.


R=antonm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=9497

[Anton Muhin, 2012-07-06 15:06:15]

https://chromiumcodereview.appspot.com/10689120/diff/1/tests/html/native_gc_t...
File tests/html/native_gc_test.dart (right):

https://chromiumcodereview.appspot.com/10689120/diff/1/tests/html/native_gc_t...
tests/html/native_gc_test.dart:40: testDiv.on.click.add(expectAsync1((e) {}));
isn't it too fragile to depend on the test order?

[podivilov, 2012-07-06 16:08:19]

https://chromiumcodereview.appspot.com/10689120/diff/1/tests/html/native_gc_t...
File tests/html/native_gc_test.dart (right):

https://chromiumcodereview.appspot.com/10689120/diff/1/tests/html/native_gc_t...
tests/html/native_gc_test.dart:40: testDiv.on.click.add(expectAsync1((e) {}));
On 2012/07/06 15:06:15, antonmuhin wrote:
> isn't it too fragile to depend on the test order?

Done.

[Anton Muhin, 2012-07-06 16:17:01]

lgtm

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
File tests/html/native_gc_test.dart (right):

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
tests/html/native_gc_test.dart:50: List list = new List(1000000);
somewhat fragile, but, I don't know better approach except for exposing gc.

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
tests/html/native_gc_test.dart:52: div.on.click.add((e) => print(list[0]));
why?

[podivilov, 2012-07-10 08:33:52]

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
File tests/html/native_gc_test.dart (right):

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
tests/html/native_gc_test.dart:52: div.on.click.add((e) => print(list[0]));
On 2012/07/06 16:17:01, antonmuhin wrote:
> why?

why not? :)

[Anton Muhin, 2012-07-10 08:41:38]

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
File tests/html/native_gc_test.dart (right):

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
tests/html/native_gc_test.dart:52: div.on.click.add((e) => print(list[0]));
It's not obvious why code which promises to trigger GC needs to install any
event listeners.

On 2012/07/10 08:33:52, podivilov wrote:
> On 2012/07/06 16:17:01, antonmuhin wrote:
> > why?
> 
> why not? :)

[podivilov, 2012-07-10 11:03:47]

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
File tests/html/native_gc_test.dart (right):

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
tests/html/native_gc_test.dart:52: div.on.click.add((e) => print(list[0]));
On 2012/07/10 08:41:38, antonmuhin wrote:
> It's not obvious why code which promises to trigger GC needs to install any
> event listeners.
> 

Is it possible that void foo() { List list = new List(1000000); } will be
compiled into no-op?
And shouldn't we somehow retain this list from embedder's code to make sure it
won't be collected on minor GC?

[Anton Muhin, 2012-07-10 11:36:16]

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
File tests/html/native_gc_test.dart (right):

https://chromiumcodereview.appspot.com/10689120/diff/5001/tests/html/native_g...
tests/html/native_gc_test.dart:52: div.on.click.add((e) => print(list[0]));
That's a good point, but in this case you'd better store into some global state,
as GC should collect div element, and therefore its closure and this reference
too.

But up to you.

On 2012/07/10 11:03:47, podivilov wrote:
> On 2012/07/10 08:41:38, antonmuhin wrote:
> > It's not obvious why code which promises to trigger GC needs to install any
> > event listeners.
> > 
> 
> Is it possible that void foo() { List list = new List(1000000); } will be
> compiled into no-op?
> And shouldn't we somehow retain this list from embedder's code to make sure it
> won't be collected on minor GC?
>