Issue 10689099: Add --trace_type_check_elimination flag for debugging purposes.

Issue 10689099: Add --trace_type_check_elimination flag for debugging purposes. (Closed)

Created:
8 years, 5 months ago by regis

Modified:
8 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add --trace_type_check_elimination flag for debugging purposes. Committed: https://code.google.com/p/dart/source/detail?r=9471

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -43 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	7 chunks	+81 lines, -39 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10689099/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10689099/diff/1/runtime/vm/flow_graph_builder.cc#newcode347 runtime/vm/flow_graph_builder.cc:347: // parameters, the type test cannot be eliminated. ...

8 years, 5 months ago (2012-07-07 23:06:04 UTC) #3

regis

8 years, 5 months ago (2012-07-09 16:58:53 UTC) #4

Thanks!

https://chromiumcodereview.appspot.com/10689099/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10689099/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:347: // parameters, the type test cannot be
eliminated.
On 2012/07/07 23:06:04, srdjan wrote:
> The comment is confusing as it implies how the method
"IsStaticTypeMoreSpecific"
> is called.  Maybe move that test to the caller instead?

Moving this test to the caller would skip the tests above returning true, even
when the value is NULL. I improved the comment.

https://chromiumcodereview.appspot.com/10689099/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:358: // TODO(regis): Eliminate the test if the
value is constant null.
On 2012/07/07 23:06:04, srdjan wrote:
> ditto

ditto

Expand Messages | Collapse Messages