Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 10689083: Compile an instance setter call when a static getter is declared, but no field (Closed)

Created:
8 years, 5 months ago by regis
Modified:
8 years, 5 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Compile an instance setter call when a static getter is declared, but no field or static setter are declared (issue 3941). Add test. Committed: https://code.google.com/p/dart/source/detail?r=9376

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -12 lines) Patch
M runtime/vm/ast.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/ast.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 1 10 chunks +23 lines, -9 lines 0 comments Download
A tests/language/getter_no_setter_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
8 years, 5 months ago (2012-07-03 01:15:29 UTC) #1
Ivan Posva
8 years, 5 months ago (2012-07-03 20:18:20 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698