Issue 10689063: Revert "Revert "First step towards having patch files for generic libraries.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10689063: Revert "Revert "First step towards having patch files for generic libraries."" (Closed)

Created:
8 years, 5 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "First step towards having patch files for generic libraries."" This reapplies r9246 without the (known) bugs. Committed: https://code.google.com/p/dart/source/detail?r=9282

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+194 lines, -35 lines)			Patch
M	lib/compiler/implementation/apiimpl.dart	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View	1 chunk	+68 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	7 chunks	+47 lines, -9 lines	1 comment	Download
A +	lib/compiler/implementation/lib/web.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A +	lib/compiler/implementation/lib/web.dartp	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/library_map.dart	View	1 chunk	+38 lines, -14 lines	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/scanner_task.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/source_file.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/source_map_builder.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://chromiumcodereview.appspot.com/10689063/diff/1/lib/compiler/implementation/elements/elements.dart File lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10689063/diff/1/lib/compiler/implementation/elements/elements.dart#newcode664 lib/compiler/implementation/elements/elements.dart:664: assert(cachedNode === null); The asserts were inverted :(

8 years, 5 months ago (2012-07-02 08:52:12 UTC) #1

LGTM.

Expand Messages | Collapse Messages