Issue 10689038: Revert "First step towards having patch files for generic libraries."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10689038: Revert "First step towards having patch files for generic libraries." (Closed)

Created:
8 years, 5 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "First step towards having patch files for generic libraries." This reverts commit r9246. TBR: floitsch Committed: https://code.google.com/p/dart/source/detail?r=9249

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -205 lines)			Patch
M	lib/compiler/implementation/apiimpl.dart	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View	1 chunk	+0 lines, -68 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	7 chunks	+9 lines, -47 lines	0 comments	Download
D	lib/compiler/implementation/lib/web.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	lib/compiler/implementation/lib/web.dartp	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	lib/compiler/implementation/library_map.dart	View	1 chunk	+14 lines, -38 lines	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	lib/compiler/implementation/scanner/scanner_task.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	lib/compiler/implementation/source_file.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/source_map_builder.dart	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Lasse Reichstein Nielsen

Made the build-bot red. Some late-added asserts that shouldn't be able to fail ... failed.

8 years, 5 months ago (2012-06-29 13:50:26 UTC) #1

LGTM.
good thing you added the asserts then.