Issue 10686003: Better breakpoint placement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10686003: Better breakpoint placement (Closed)

Created:
8 years, 6 months ago by hausner

Modified:
8 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, Alan Knight

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Better breakpoint placement Instead of using token distance to find the first possible breakpoint position in a line, use generated code address, so the debugger breaks before the first call on a source line. Fix issue 3653 http://code.google.com/p/dart/issues/detail?id=3318 Committed: https://code.google.com/p/dart/source/detail?r=9176

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -48 lines)			Patch
M	runtime/vm/debugger.h	View	1 2 3 4	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2 3 4	8 chunks	+47 lines, -16 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1 2 3 4	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	4 chunks	+11 lines, -9 lines	0 comments	Download
M	runtime/vm/scanner.h	View	1 2 3 4	1 chunk	+8 lines, -3 lines	0 comments	Download
M	runtime/vm/scanner.cc	View	1 2 3 4	1 chunk	+23 lines, -4 lines	0 comments	Download
M	runtime/vm/scanner_test.cc	View	1 2 3 4	1 chunk	+9 lines, -4 lines	0 comments	Download
M	tools/ddbg.dart	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/10686003/diff/10003/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): http://codereview.chromium.org/10686003/diff/10003/runtime/vm/debugger.cc#newcode834 runtime/vm/debugger.cc:834: // neares one to the beginning of the ...

8 years, 6 months ago (2012-06-27 02:00:30 UTC) #2

hausner

8 years, 5 months ago (2012-06-27 17:09:18 UTC) #3

http://codereview.chromium.org/10686003/diff/10003/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

http://codereview.chromium.org/10686003/diff/10003/runtime/vm/debugger.cc#new...
runtime/vm/debugger.cc:834: // neares one to the beginning of the range, in
terms of token position.
On 2012/06/27 02:00:31, asiva wrote:
> nearest

Done.

Expand Messages | Collapse Messages