Adds support for layout tests.

Adds support for layout tests.

Committed: https://code.google.com/p/dart/source/detail?r=9207

[Siggi Cherem (dart-lang), 2012-06-27 01:50:42]

This adds support for running layout tests with test.dart and adds a sample
layout test.

Unfortunately, the image file is not shown in rietveld :(

https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
File tools/testing/dart/browser_test.dart (right):

https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
tools/testing/dart/browser_test.dart:5: String getHtmlContents(String title,
I noticed that these should start with lower-case (common style guide that we
use everywhere else)

https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
tools/testing/dart/test_suite.dart:892: *     // WebTest=true
this is something I'm adding on a separate CL
(https://chromiumcodereview.appspot.com//10685009), but I went ahead and started
writing the documentation right away assuming I'll submit this on a second step.

[Bill Hesse, 2012-06-27 09:24:37]

LGTM.

I know some people don't want to add more comments to the tests, and to
customize TestSuite classes to handle the new types of tests, and I agree that
would be good.  But this change can easily be refactored to do that, and solving
the problem of many options in the test comments should be solved by removing
all of them, not just limiting their number.

I still like the idea that a custom test suite could just check if there is an
expected output file with the same name as the test, and use that expected
output file if it exists.  Wouldn't that be better than adding a reference to it
in the test file?

https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
tools/testing/dart/test_suite.dart:905: *   By default tests are run without
expectation files: test.dart assumes
Say "web tests" here, not just "tests".  This only applies to browser tests,
right?

[Siggi Cherem (dart-lang), 2012-06-27 20:21:05]

PTAL 

I changed it so that the comment is not necessary. But kept some documentation
around for future reference.

I also used Path for the path manipulations I was doing.

It seems that the dart binary under tools/testing/bin is not up to date (it
doesn't have "Path" in its snapshot of dart:io). Is there a plan to update it
soon (otherwise I can remporarily rewrite things using _dirFromFile...)

https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
tools/testing/dart/test_suite.dart:905: *   By default tests are run without
expectation files: test.dart assumes
On 2012/06/27 09:24:37, Bill Hesse wrote:
> Say "web tests" here, not just "tests".  This only applies to browser tests,
> right?

Done.

[Bill Hesse, 2012-06-28 11:51:27]

Thanks, I like this a lot better.  LGTM.


On 2012/06/27 20:21:05, sigmund wrote:
> PTAL 
> 
> I changed it so that the comment is not necessary. But kept some documentation
> around for future reference.
> 
> I also used Path for the path manipulations I was doing.
> 
> It seems that the dart binary under tools/testing/bin is not up to date (it
> doesn't have "Path" in its snapshot of dart:io). Is there a plan to update it
> soon (otherwise I can remporarily rewrite things using _dirFromFile...)
> 
>
https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
> File tools/testing/dart/test_suite.dart (right):
> 
>
https://chromiumcodereview.appspot.com/10683009/diff/6001/tools/testing/dart/...
> tools/testing/dart/test_suite.dart:905: *   By default tests are run without
> expectation files: test.dart assumes
> On 2012/06/27 09:24:37, Bill Hesse wrote:
> > Say "web tests" here, not just "tests".  This only applies to browser tests,
> > right?
> 
> Done.