Issue 10674007: Don't try to look up the root package in the default source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10674007: Don't try to look up the root package in the default source. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't try to look up the root package in the default source. Committed: https://code.google.com/p/dart/source/detail?r=9184

Patch Set 2 : Add tests #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -9 lines)			Patch
	M	utils/pub/version_solver.dart	View		2 chunks	+14 lines, -5 lines	0 comments	Download
	M	utils/tests/pub/version_solver_test.dart	View	1	2 chunks	+10 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM, assuming you add the comment. https://chromiumcodereview.appspot.com/10674007/diff/3001/utils/tests/pub/version_solver_test.dart File utils/tests/pub/version_solver_test.dart (right): https://chromiumcodereview.appspot.com/10674007/diff/3001/utils/tests/pub/version_solver_test.dart#newcode196 utils/tests/pub/version_solver_test.dart:196: root = package; ...

8 years, 5 months ago (2012-06-26 23:39:09 UTC) #2

nweiz

8 years, 5 months ago (2012-06-27 18:05:12 UTC) #3

https://chromiumcodereview.appspot.com/10674007/diff/3001/utils/tests/pub/ver...
File utils/tests/pub/version_solver_test.dart (right):

https://chromiumcodereview.appspot.com/10674007/diff/3001/utils/tests/pub/ver...
utils/tests/pub/version_solver_test.dart:196: root = package;
On 2012/06/26 23:39:09, Bob Nystrom wrote:
> Can you add a comment here that we specifically don't add my app to the source
> so that we can catch attempts to look it up?

Done.

Expand Messages | Collapse Messages

Issue 10674007: Don't try to look up the root package in the default source. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add tests #

Messages