Issue 10669031: Support V8EnabledAtRuntime in constructors.

Issue 10669031: Support V8EnabledAtRuntime in constructors. (Closed)

Created:
8 years, 6 months ago by Anton Muhin

Modified:
8 years, 6 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support V8EnabledAtRuntime in constructors. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=9107

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -17 lines)			Patch
	M	lib/dom/scripts/databasebuilder.py	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	lib/dom/scripts/systemnative.py	View	1 2	6 chunks	+32 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

podivilov

https://chromiumcodereview.appspot.com/10669031/diff/1/lib/dom/scripts/databasebuilder.py File lib/dom/scripts/databasebuilder.py (right): https://chromiumcodereview.appspot.com/10669031/diff/1/lib/dom/scripts/databasebuilder.py#newcode591 lib/dom/scripts/databasebuilder.py:591: def pair(s): return (s, s.lower()) Please move this logic ...

8 years, 6 months ago (2012-06-26 10:51:13 UTC) #2

Anton Muhin

8 years, 6 months ago (2012-06-26 12:16:35 UTC) #3

podivilov

lgtm https://chromiumcodereview.appspot.com/10669031/diff/3002/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10669031/diff/3002/lib/dom/scripts/systemnative.py#newcode17 lib/dom/scripts/systemnative.py:17: def toWebKitName(name): please move this helper to the ...

8 years, 6 months ago (2012-06-26 12:33:01 UTC) #4

Anton Muhin

8 years, 6 months ago (2012-06-26 12:37:25 UTC) #5

https://chromiumcodereview.appspot.com/10669031/diff/3002/lib/dom/scripts/sys...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10669031/diff/3002/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:17: def toWebKitName(name):
On 2012/06/26 12:33:01, podivilov wrote:
> please move this helper to the end of the file and rename to _ToWebKitName.

Done.

Expand Messages | Collapse Messages