Issue 10668034: Recognize leaf functions: skip stack check and populating the pc slot, store the pc slot lazily in …

Issue 10668034: Recognize leaf functions: skip stack check and populating the pc slot, store the pc slot lazily in … (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google), Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Recognize leaf functions: skip stack check and populating the pc slot, store the pc slot lazily in case of deoptimization. Committed: https://code.google.com/p/dart/source/detail?r=9095

Patch Set 8 : #

Total comments: 4

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -32 lines)			Patch
M	runtime/vm/assembler_macros_ia32.h	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_macros_ia32.cc	View	1 2 3 4 5	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_macros_x64.h	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_macros_x64.cc	View	1 2 3 4 5 6	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1 2 3 4 5	1 chunk	+7 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 2 3 4 5 6	4 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3 4 5	3 chunks	+7 lines, -1 line	2 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3 4 5 6	8 chunks	+32 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3 4 5	3 chunks	+7 lines, -1 line	2 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4 5	8 chunks	+32 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1 2 3 4 5	1 chunk	+19 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4 5	1 chunk	+24 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5 6 7	2 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4 5 6 7	2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10668034/diff/14010/runtime/vm/flow_graph_compiler_ia32.h File runtime/vm/flow_graph_compiler_ia32.h (right): https://chromiumcodereview.appspot.com/10668034/diff/14010/runtime/vm/flow_graph_compiler_ia32.h#newcode266 runtime/vm/flow_graph_compiler_ia32.h:266: // Returns true if the generated code does ...

8 years, 6 months ago (2012-06-25 23:46:09 UTC) #2

srdjan

8 years, 6 months ago (2012-06-25 23:50:22 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10668034/diff/14010/runtime/vm/flow_gr...
File runtime/vm/flow_graph_compiler_ia32.h (right):

https://chromiumcodereview.appspot.com/10668034/diff/14010/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_ia32.h:266: // Returns true if the generated code
does not call other Dart code.
On 2012/06/25 23:46:09, regis wrote:
> Is a runtime call considered Dart code?

Added or runtime.

https://chromiumcodereview.appspot.com/10668034/diff/14010/runtime/vm/flow_gr...
File runtime/vm/flow_graph_compiler_x64.h (right):

https://chromiumcodereview.appspot.com/10668034/diff/14010/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_x64.h:266: // Returns true if the generated code
does not call other Dart code.
On 2012/06/25 23:46:09, regis wrote:
> ditto

Done.

Expand Messages | Collapse Messages