Issue 10667013: Transitively mark inputs as live when they are generateAtUseSite.

Issue 10667013: Transitively mark inputs as live when they are generateAtUseSite. (Closed)

Created:
8 years, 6 months ago by floitsch

Modified:
8 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Transitively mark inputs as live when they are generateAtUseSite. Committed: https://code.google.com/p/dart/source/detail?r=9119

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -8 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	lib/compiler/implementation/ssa/variable_allocator.dart	View		6 chunks	+25 lines, -7 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

I have tried for hours to find a case where we actually trigger this, but ...

8 years, 6 months ago (2012-06-25 14:17:52 UTC) #1

ngeoffray

https://chromiumcodereview.appspot.com/10667013/diff/1/lib/compiler/implementation/ssa/variable_allocator.dart File lib/compiler/implementation/ssa/variable_allocator.dart (right): https://chromiumcodereview.appspot.com/10667013/diff/1/lib/compiler/implementation/ssa/variable_allocator.dart#newcode239 lib/compiler/implementation/ssa/variable_allocator.dart:239: // HPhis are treated specially. Do you remember if ...

8 years, 4 months ago (2012-08-17 13:04:53 UTC) #3

floitsch

8 years, 2 months ago (2012-10-03 09:22:39 UTC) #4

https://chromiumcodereview.appspot.com/10667013/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/variable_allocator.dart (right):

https://chromiumcodereview.appspot.com/10667013/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/variable_allocator.dart:239: // HPhis are
treated specially.
On 2012/08/17 13:04:53, ngeoffray wrote:
> Do you remember if removing the HPhi check triggered an error?

Sorry. Don't remember.

Expand Messages | Collapse Messages