Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10665038: Remove old code generator. (Closed)

Created:
8 years, 6 months ago by regis
Modified:
8 years, 5 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)
Visibility:
Public.

Description

Remove old code generator. Committed: https://code.google.com/p/dart/source/detail?r=9122

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -6782 lines) Patch
M runtime/vm/code_generator.h View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 2 chunks +1 line, -58 lines 0 comments Download
D runtime/vm/code_generator_arm.h View 1 2 1 chunk +0 lines, -66 lines 0 comments Download
D runtime/vm/code_generator_ia32.h View 1 2 1 chunk +0 lines, -270 lines 0 comments Download
D runtime/vm/code_generator_ia32.cc View 1 2 1 chunk +0 lines, -2979 lines 0 comments Download
D runtime/vm/code_generator_x64.h View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
M runtime/vm/code_patcher_ia32_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_x64_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 11 chunks +18 lines, -133 lines 0 comments Download
M runtime/vm/dart_entry.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 2 3 chunks +53 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 5 chunks +10 lines, -9 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 2 chunks +1 line, -14 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D runtime/vm/opt_code_generator.h View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
D runtime/vm/opt_code_generator_arm.h View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D runtime/vm/opt_code_generator_ia32.h View 1 2 1 chunk +0 lines, -163 lines 0 comments Download
D runtime/vm/opt_code_generator_ia32.cc View 1 2 1 chunk +0 lines, -2894 lines 0 comments Download
D runtime/vm/opt_code_generator_x64.h View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 2 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
8 years, 6 months ago (2012-06-26 00:23:20 UTC) #1
srdjan
LGTM with one comment https://chromiumcodereview.appspot.com/10665038/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://chromiumcodereview.appspot.com/10665038/diff/1/runtime/vm/compiler.cc#newcode217 runtime/vm/compiler.cc:217: UNREACHABLE(); We can bailout of ...
8 years, 6 months ago (2012-06-26 16:06:51 UTC) #2
srdjan
LGTM (CC-d Slava and Florian so that they are aware of the new code for ...
8 years, 6 months ago (2012-06-26 17:30:08 UTC) #3
Florian Schneider
8 years, 5 months ago (2012-06-29 15:58:20 UTC) #4 
minus 6000 lines. Nice!

On 2012/06/26 17:30:08, srdjan wrote:
> LGTM
> 
> (CC-d Slava and Florian so that they are aware of the new code for bailing out
> from SSA building).

Powered by Google App Engine
This is Rietveld 408576698