Issue 10665035: Prepare for writing token streams directly into a snapshot and reading it directly from the snapsho…

Issue 10665035: Prepare for writing token streams directly into a snapshot and reading it directly from the snapsho… (Closed)

Created:
8 years, 6 months ago by siva

Modified:
8 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Prepare for writing token streams directly into a snapshot and reading it directly from the snapshot using memmove. Committed: https://code.google.com/p/dart/source/detail?r=9098

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -15 lines)			Patch
M	vm/datastream.h	View	1 2 3	5 chunks	+27 lines, -10 lines	0 comments	Download
M	vm/raw_object_snapshot.cc	View		2 chunks	+9 lines, -5 lines	0 comments	Download
M	vm/snapshot.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://chromiumcodereview.appspot.com/10665035/diff/5001/vm/datastream.h File vm/datastream.h (right): https://chromiumcodereview.appspot.com/10665035/diff/5001/vm/datastream.h#newcode166 vm/datastream.h:166: if ((current_ + len) >= end_) { You should ...

8 years, 6 months ago (2012-06-25 23:06:22 UTC) #2

siva

http://codereview.chromium.org/10665035/diff/5001/vm/datastream.h File vm/datastream.h (right): http://codereview.chromium.org/10665035/diff/5001/vm/datastream.h#newcode166 vm/datastream.h:166: if ((current_ + len) >= end_) { Changed to ...

8 years, 6 months ago (2012-06-25 23:46:03 UTC) #3

Ivan Posva

https://chromiumcodereview.appspot.com/10665035/diff/5/vm/datastream.h File vm/datastream.h (right): https://chromiumcodereview.appspot.com/10665035/diff/5/vm/datastream.h#newcode197 vm/datastream.h:197: Utils::Maximum(kBufferIncrementSize, size_needed)); round up to kBufferIncrementSize?

8 years, 6 months ago (2012-06-25 23:50:53 UTC) #4

siva

8 years, 6 months ago (2012-06-26 00:17:40 UTC) #7

https://chromiumcodereview.appspot.com/10665035/diff/5/vm/datastream.h
File vm/datastream.h (right):

https://chromiumcodereview.appspot.com/10665035/diff/5/vm/datastream.h#newcod...
vm/datastream.h:197: Utils::Maximum(kBufferIncrementSize, size_needed));
On 2012/06/25 23:50:53, Ivan Posva wrote:
> round up to kBufferIncrementSize?

Done.

Expand Messages | Collapse Messages