Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 10665033: Initial support for hide and show in import directives (Closed)

Created:
8 years, 6 months ago by Brian Wilkerson
Modified:
8 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Initial support for hide and show in import directives. This updates the AST structure to support the new import directive format and includes an untested hint at what the parser changes will likely be (for context), but doesn't change the current behavior of analyzer. Committed: https://code.google.com/p/dart/source/detail?r=9116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -13 lines) Patch
M compiler/java/com/google/dart/compiler/ast/ASTVisitor.java View 2 chunks +13 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartImportDirective.java View 3 chunks +21 lines, -1 line 0 comments Download
A compiler/java/com/google/dart/compiler/ast/ImportCombinator.java View 1 chunk +33 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/ast/ImportHideCombinator.java View 1 chunk +76 lines, -0 lines 0 comments Download
A compiler/java/com/google/dart/compiler/ast/ImportShowCombinator.java View 1 chunk +77 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 4 chunks +50 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Brian Wilkerson
8 years, 6 months ago (2012-06-25 21:51:41 UTC) #1
scheglov
8 years, 6 months ago (2012-06-26 00:58:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698