Issue 10665028: Add filter for vm specific tests to dart2js status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10665028: Add filter for vm specific tests to dart2js status file. (Closed)

Created:
8 years, 6 months ago by regis

Modified:
8 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add filter for vm specific tests to dart2js status file. Committed: https://code.google.com/p/dart/source/detail?r=9073

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	tests/language/language_dart2js.status	View		3 chunks	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 6 months ago (2012-06-25 17:59:02 UTC) #2

LGTM -ip

https://chromiumcodereview.appspot.com/10665028/diff/1/tests/language/languag...
File tests/language/language_dart2js.status (right):

https://chromiumcodereview.appspot.com/10665028/diff/1/tests/language/languag...
tests/language/language_dart2js.status:5: [ $compiler == dart2js ]
This line should not be needed as this status file is only used for dart2js
compiler runs.

On the other hand it is repeated in the tests below as well, so I guess this is
the style.

Expand Messages | Collapse Messages