Issue 10664004: Fix issue 1968, replace usage of inline 'asm' constructs in 'stack alignment', 'jump to exception h…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10664004: Fix issue 1968, replace usage of inline 'asm' constructs in 'stack alignment', 'jump to exception h… (Closed)

Created:
8 years, 6 months ago by siva

Modified:
8 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Fix issue 1968, replace usage of inline 'asm' constructs in 'stack alignment', 'jump to exception handler' and 'jump to error handler' code with calls to appropriate stubs. Committed: https://code.google.com/p/dart/source/detail?r=9071

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -311 lines)			Patch
M	vm/assembler_arm.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	vm/assembler_ia32.h	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	vm/assembler_x64.h	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	vm/cpu.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	vm/cpu_arm.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	vm/cpu_ia32.cc	View	1	1 chunk	+0 lines, -102 lines	0 comments	Download
M	vm/cpu_x64.cc	View		1 chunk	+0 lines, -85 lines	0 comments	Download
M	vm/exceptions.cc	View	1	5 chunks	+64 lines, -11 lines	0 comments	Download
M	vm/native_arguments.h	View		2 chunks	+23 lines, -0 lines	0 comments	Download
M	vm/os.h	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download
M	vm/os_linux.cc	View	1 2 3 4	1 chunk	+0 lines, -11 lines	0 comments	Download
M	vm/os_macos.cc	View	1 2 3 4	1 chunk	+0 lines, -9 lines	0 comments	Download
M	vm/os_win.cc	View	1 2 3 4	1 chunk	+0 lines, -5 lines	0 comments	Download
M	vm/stub_code.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	vm/stub_code_arm.cc	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	vm/stub_code_ia32.cc	View	1 2 3	1 chunk	+46 lines, -0 lines	0 comments	Download
M	vm/stub_code_x64.cc	View		1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages