Issue 10663029: - Sort sources in gyp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10663029: - Sort sources in gyp files. (Closed)

Created:
8 years, 6 months ago by Ivan Posva

Modified:
8 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Sort sources in gyp files. Committed: https://code.google.com/p/dart/source/detail?r=9091

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/bin/io_sources.gypi	View		2 chunks	+2 lines, -2 lines	1 comment	Download
	M	runtime/vm/vm_sources.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

siva

8 years, 6 months ago (2012-06-25 23:10:33 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10663029/diff/1/runtime/bin/io_sources...
File runtime/bin/io_sources.gypi (right):

https://chromiumcodereview.appspot.com/10663029/diff/1/runtime/bin/io_sources...
runtime/bin/io_sources.gypi:44: 'stream_util.dart',
stream before string?

Expand Messages | Collapse Messages