Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 10662048: Build uses dart2js.bat on Windows (Closed)

Created:
8 years, 6 months ago by Johnni Winther
Modified:
8 years, 5 months ago
Reviewers:
ahe, sra1
CC:
reviews_dartlang.org, Kathy Walrath, vsm
Visibility:
Public.

Description

Copy of html_frog added to dartdoc/frog/lib Build uses dart2js.bat on Windows BUG=3775 TEST= Committed: https://code.google.com/p/dart/source/detail?r=9149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
A + lib/dartdoc/frog/lib/html_frog.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/dartdoc/frog/reader.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/isolate/isolate_frog.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
8 years, 6 months ago (2012-06-26 13:43:28 UTC) #1
ahe
lgtm
8 years, 6 months ago (2012-06-26 19:47:16 UTC) #2
sra1
Why was html_frog.dart copied to this directory? lib/html/html_frog.dart is regenerated frequently so the copy will ...
8 years, 5 months ago (2012-06-28 23:41:58 UTC) #3
sra1
8 years, 5 months ago (2012-07-02 16:56:40 UTC) #4
On 2012/06/28 23:41:58, sra1 wrote:
> Why was html_frog.dart copied to this directory?
> 
> lib/html/html_frog.dart is regenerated frequently so the copy will rapidly
> become out of date.
> 
> We have a process for generating dart:html documentation:
> The correct documentation should be added to the .dartdoc files under
> lib/html/doc.
> This is used in preference to the html_frog.dart documentation when generating
> documentation.
> The plan is that we will write a tool that merges from the .dartdoc files into
> html/frog/html_frog.dart as part of the regular regeneration so that the
dartdoc
> documentation is live in the editor.
> 
> Where does the new copy figure in this workflow?

| Well, it doesn't. The file was copied to the frog lib because dartdoc (which
still uses frog) couldn't | find it otherwise.
|
| I'm working on converting dartdoc/apidoc to use dart2js instead of frog, and
this should resolve the | | issue appropriately. I hope to deploy this new
version of dartdoc/apidoc late next week. Can we accept | the possible
inconsistency until then?

Ok, so long as we delete the duplicate file at that time.

Powered by Google App Engine
This is Rietveld 408576698