Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 10662047: Remove ParameterAdapters for all types except for String. (Closed)

Created:
8 years, 6 months ago by podivilov
Modified:
8 years, 6 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove ParameterAdapters for all types except for String. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=9113

Patch Set 1 #

Total comments: 7

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M lib/dom/scripts/generator.py View 1 3 chunks +30 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
podivilov
8 years, 6 months ago (2012-06-26 12:28:41 UTC) #1
Anton Muhin
https://chromiumcodereview.appspot.com/10662047/diff/1/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10662047/diff/1/lib/dom/scripts/generator.py#newcode658 lib/dom/scripts/generator.py:658: if self.native_type() == 'String': maybe introduce a separate typeinfo ...
8 years, 6 months ago (2012-06-26 12:56:41 UTC) #2
podivilov
https://chromiumcodereview.appspot.com/10662047/diff/1/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10662047/diff/1/lib/dom/scripts/generator.py#newcode658 lib/dom/scripts/generator.py:658: if self.native_type() == 'String': On 2012/06/26 12:56:41, antonmuhin wrote: ...
8 years, 6 months ago (2012-06-26 13:14:49 UTC) #3
Anton Muhin
https://chromiumcodereview.appspot.com/10662047/diff/1/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10662047/diff/1/lib/dom/scripts/generator.py#newcode658 lib/dom/scripts/generator.py:658: if self.native_type() == 'String': What do you mean be ...
8 years, 6 months ago (2012-06-26 13:24:43 UTC) #4
podivilov
https://chromiumcodereview.appspot.com/10662047/diff/1/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10662047/diff/1/lib/dom/scripts/generator.py#newcode714 lib/dom/scripts/generator.py:714: return re.sub(r'(^| )([a-z]\w*)', replace, self.native_type()) On 2012/06/26 13:24:43, antonmuhin ...
8 years, 6 months ago (2012-06-26 13:58:31 UTC) #5
Anton Muhin
8 years, 6 months ago (2012-06-26 14:27:12 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698