Unit test filtering.

Unit test filtering. This is just the library support part, it does
not affect the Dart test framework; as such, I have for now removed the 
code that checks if a filter was passed in the Options.
Committed: https://code.google.com/p/dart/source/detail?r=9088

[gram, 2012-06-25 19:23:50]

Unit test filtering. This is just the library support part, it does not affect
the Dart test framework, so should be non-controversial.

As it does not include the part that passes --filter to the VM, I have for now
removed the code that checks if a filter was passed in the Options. Filters can
only be set by calling setFilter().

[gram, 2012-06-25 19:24:54]

I figure that splitting this out means the rest of the change can focus on how
we hook this into the greater test framework, which is something like requires a
different audience.

On 2012/06/25 19:23:50, gram wrote:
> Unit test filtering. This is just the library support part, it does not affect
> the Dart test framework, so should be non-controversial.
> 
> As it does not include the part that passes --filter to the VM, I have for now
> removed the code that checks if a filter was passed in the Options. Filters
can
> only be set by calling setFilter().

[Siggi Cherem (dart-lang), 2012-06-25 21:40:59]

https://chromiumcodereview.appspot.com/10662022/diff/1/lib/unittest/unittest....
File lib/unittest/unittest.dart (right):

https://chromiumcodereview.appspot.com/10662022/diff/1/lib/unittest/unittest....
lib/unittest/unittest.dart:254: void setFilter(String filter) {
use a setter instead:

String set filter(String value) {
 ...
}

https://chromiumcodereview.appspot.com/10662022/diff/1/lib/unittest/unittest....
lib/unittest/unittest.dart:263: String getFilter() {
use a getter instead:

String get filter => _filter;

https://chromiumcodereview.appspot.com/10662022/diff/1/lib/unittest/unittest....
lib/unittest/unittest.dart:666: if (_filter != null) {
To simplify the API, I'm inclined to just make _filter public (remove the getter
and setter) and check where for _fileter != null or != '')

[eub, 2012-06-25 21:45:45]

The change looks okay from my POV.  I do expect people want to be looped in to
keep an eye on the evolution of the codebase, even if it's "just library
support"; +Peter.