Issue 10659005: Implement type cast in the VM.

Issue 10659005: Implement type cast in the VM. (Closed)

Created:
8 years, 6 months ago by regis

Modified:
8 years, 6 months ago

Reviewers:
srdjan, hausner, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement type cast in the VM. Committed: https://code.google.com/p/dart/source/detail?r=9070

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+290 lines, -38 lines)			Patch
M	runtime/lib/error.dart	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download
M	runtime/vm/ast.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/exceptions.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/exceptions.cc	View	1 2	2 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2	4 chunks	+48 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2	3 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2	3 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1 2	3 chunks	+14 lines, -7 lines	0 comments	Download
M	runtime/vm/token.h	View	1 2	3 chunks	+10 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/pseudo_kw_test.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/type_cast_vm_test.dart	View		1 chunk	+158 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10659005/diff/1015/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10659005/diff/1015/runtime/vm/flow_graph_builder.cc#newcode692 runtime/vm/flow_graph_builder.cc:692: const String& dst_name = String::ZoneHandle(String::NewSymbol("type cast")); Factor out ...

8 years, 6 months ago (2012-06-23 00:04:29 UTC) #2

hausner

LGTM. I think you should also add "as" to the language/pseudo_kw_test.dart test.

8 years, 6 months ago (2012-06-25 15:52:40 UTC) #3

regis

8 years, 6 months ago (2012-06-25 17:34:56 UTC) #4

Thanks!

I have also edited tests/language/pseudo_kw_test.dart as suggested by Matthias.

-- Regis

https://chromiumcodereview.appspot.com/10659005/diff/1015/runtime/vm/flow_gra...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10659005/diff/1015/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:692: const String& dst_name =
String::ZoneHandle(String::NewSymbol("type cast"));
On 2012/06/23 00:04:29, srdjan wrote:
> Factor out the string "type cast" used at least in two places.

Done.

https://chromiumcodereview.appspot.com/10659005/diff/1015/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:800: } else if
(Token::IsTypeCastOperator(node->kind())) {
On 2012/06/23 00:04:29, srdjan wrote:
> No else needed.

Done.

Expand Messages | Collapse Messages