Issue 10657012: Intrinsify fixed and growable array allocation on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10657012: Intrinsify fixed and growable array allocation on x64. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Intrinsify fixed and growable array allocation on x64. Committed: https://code.google.com/p/dart/source/detail?r=9075

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -4 lines)			Patch
M	runtime/vm/intrinsifier_ia32.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2	3 chunks	+163 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10657012/diff/3/runtime/vm/intrinsifier_x64.cc File runtime/vm/intrinsifier_x64.cc (right): https://chromiumcodereview.appspot.com/10657012/diff/3/runtime/vm/intrinsifier_x64.cc#newcode37 runtime/vm/intrinsifier_x64.cc:37: // and it computed as: and is computed ...

8 years, 6 months ago (2012-06-25 17:22:44 UTC) #2

srdjan

8 years, 6 months ago (2012-06-25 17:35:45 UTC) #3

https://chromiumcodereview.appspot.com/10657012/diff/3/runtime/vm/intrinsifie...
File runtime/vm/intrinsifier_x64.cc (right):

https://chromiumcodereview.appspot.com/10657012/diff/3/runtime/vm/intrinsifie...
runtime/vm/intrinsifier_x64.cc:37: // and it computed as:
On 2012/06/25 17:22:44, asiva wrote:
> and is computed as

Yes and fixed it on 5 other places. The curse of copy & paste.

https://chromiumcodereview.appspot.com/10657012/diff/3/runtime/vm/intrinsifie...
runtime/vm/intrinsifier_x64.cc:107: // TAX: new object start as a tagged
pointer.
On 2012/06/25 17:22:44, asiva wrote:
> RAX: new object

Done.

https://chromiumcodereview.appspot.com/10657012/diff/3/runtime/vm/intrinsifie...
runtime/vm/intrinsifier_x64.cc:205: // and it computed as:
On 2012/06/25 17:22:44, asiva wrote:
> and is computed as:

Done.

Expand Messages | Collapse Messages

Issue 10657012: Intrinsify fixed and growable array allocation on x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages