Issue 10651008: Minimize differences between ia32 and x64 sources to facilitate maintenance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10651008: Minimize differences between ia32 and x64 sources to facilitate maintenance. (Closed)

Created:
8 years, 6 months ago by regis

Modified:
8 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Minimize differences between ia32 and x64 sources to facilitate maintenance. Committed: https://code.google.com/p/dart/source/detail?r=9012

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -57 lines)			Patch
	M	runtime/vm/intermediate_language_ia32.cc	View		19 chunks	+30 lines, -20 lines	2 comments	Download
	M	runtime/vm/intermediate_language_x64.cc	View		26 chunks	+59 lines, -37 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10651008/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10651008/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode14 runtime/vm/intermediate_language_ia32.cc:14: #include "vm/parser.h" Why do we need this include?

8 years, 6 months ago (2012-06-22 00:34:40 UTC) #2

regis

8 years, 6 months ago (2012-06-22 01:24:53 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10651008/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10651008/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:14: #include "vm/parser.h"
On 2012/06/22 00:34:40, srdjan wrote:
> Why do we need this include?

Actually, I wonder why it was not needed in the first place. Removing it on the
x64 side results in a compilation error. I suspect that the x64 compiler is
doing more aggressive inlining and the structure of ParsedFunction is needed.
The include does not hurt here.

Expand Messages | Collapse Messages