Issue 10645003: Do not collect stack trace unnecessarily

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10645003: Do not collect stack trace unnecessarily (Closed)

Created:
8 years, 6 months ago by hausner

Modified:
8 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, Anton Muhin

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not collect stack trace unnecessarily The debugger collected stack traces on each exception throw even when the debugger client specifies "no pause on exception". This fixes the asserts that Anton saw in some tests. Committed: https://code.google.com/p/dart/source/detail?r=8996

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	runtime/vm/debugger.cc	View		3 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages