Issue 10642026: Do not issue Mint/Smi code sequence if we have only Smi/Smi comnbination.

Issue 10642026: Do not issue Mint/Smi code sequence if we have only Smi/Smi comnbination. (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not issue Mint/Smi code sequence if we have only Smi/Smi comnbination. Committed: https://code.google.com/p/dart/source/detail?r=9044

Patch Set 7 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -32 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4 5 6	3 chunks	+53 lines, -32 lines	0 comments	Download
	M	runtime/vm/intermediate_language.h	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

https://chromiumcodereview.appspot.com/10642026/diff/3001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://chromiumcodereview.appspot.com/10642026/diff/3001/runtime/vm/flow_graph_optimizer.cc#newcode139 runtime/vm/flow_graph_optimizer.cc:139: return false; With this change, you will not inline ...

8 years, 6 months ago (2012-06-22 20:09:03 UTC) #2

srdjan

PTAL https://chromiumcodereview.appspot.com/10642026/diff/3001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://chromiumcodereview.appspot.com/10642026/diff/3001/runtime/vm/flow_graph_optimizer.cc#newcode139 runtime/vm/flow_graph_optimizer.cc:139: return false; On 2012/06/22 20:09:03, regis wrote: > ...

8 years, 6 months ago (2012-06-22 20:36:47 UTC) #3

regis

LGTM with one tiny suggestion. Much better! https://chromiumcodereview.appspot.com/10642026/diff/8003/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10642026/diff/8003/runtime/vm/intermediate_language.h#newcode1533 runtime/vm/intermediate_language.h:1533: kIllegalOperands, Would ...

8 years, 6 months ago (2012-06-22 20:50:12 UTC) #4

srdjan

8 years, 6 months ago (2012-06-22 20:54:26 UTC) #5

https://chromiumcodereview.appspot.com/10642026/diff/8003/runtime/vm/intermed...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10642026/diff/8003/runtime/vm/intermed...
runtime/vm/intermediate_language.h:1533: kIllegalOperands,
On 2012/06/22 20:50:12, regis wrote:
> Would kUnrecognizedOperands or kDynamicOperands be a better name?

kDynamicOperands

Expand Messages | Collapse Messages