Issue 10642017: Make sure that constructor bodies are added to the resolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10642017: Make sure that constructor bodies are added to the resolver (Closed)

Created:
8 years, 6 months ago by Søren Gjesse

Modified:
8 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure that constructor bodies are added to the resolver R=ahe@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9030

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	lib/compiler/implementation/compiler.dart	View		1 chunk	+4 lines, -1 line	2 comments	Download
	M	lib/compiler/implementation/enqueue.dart	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://chromiumcodereview.appspot.com/10642017/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://chromiumcodereview.appspot.com/10642017/diff/1/lib/compiler/implementation/compiler.dart#newcode618 lib/compiler/implementation/compiler.dart:618: enqueuer.resolution.resolvedElements[work.element] = work.resolutionTree; I'm not liking this. Could ...

8 years, 6 months ago (2012-06-22 10:31:22 UTC) #2

Søren Gjesse

8 years, 6 months ago (2012-06-22 11:52:35 UTC) #3

https://chromiumcodereview.appspot.com/10642017/diff/1/lib/compiler/implement...
File lib/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/10642017/diff/1/lib/compiler/implement...
lib/compiler/implementation/compiler.dart:618:
enqueuer.resolution.resolvedElements[work.element] = work.resolutionTree;
On 2012/06/22 10:31:22, ahe wrote:
> I'm not liking this. Could you add a todo for me to clean this up?

Done.

Expand Messages | Collapse Messages