Add methods to dart:io Path.

Add methods to dart:io Path.

Add .append, which adds a segment to the end of a Path, and
.pathWithoutExtension, which removes the extension (part after .),
from the filename at the end of a path, and returns the new path.

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=9028

[Bill Hesse, 2012-06-21 15:07:33]

https://chromiumcodereview.appspot.com/10638002/diff/1001/tests/standalone/io...
File tests/standalone/io/path_test.dart (right):

https://chromiumcodereview.appspot.com/10638002/diff/1001/tests/standalone/io...
tests/standalone/io/path_test.dart:46: 'canonical directory trailing');
Remove 'directory'

https://chromiumcodereview.appspot.com/10638002/diff/1001/tests/standalone/io...
tests/standalone/io/path_test.dart:65: 'absolute directory canonical trailing');
remove directory

https://chromiumcodereview.appspot.com/10638002/diff/1001/tests/standalone/io...
tests/standalone/io/path_test.dart:164: testAppendConcat('/a/b', 'c', '/a/b/c');
Remove "Concat"

[Anders Johnsen, 2012-06-22 07:33:45]

LGTM, very neat.

https://chromiumcodereview.appspot.com/10638002/diff/3001/runtime/bin/path.dart
File runtime/bin/path.dart (right):

https://chromiumcodereview.appspot.com/10638002/diff/3001/runtime/bin/path.da...
runtime/bin/path.dart:173: String get pathWithoutExtension();
Return type not consistent with comment. Should be Path.

[Mads Ager (google), 2012-06-22 07:41:40]

https://chromiumcodereview.appspot.com/10638002/diff/3001/runtime/bin/path.dart
File runtime/bin/path.dart (right):

https://chromiumcodereview.appspot.com/10638002/diff/3001/runtime/bin/path.da...
runtime/bin/path.dart:173: String get pathWithoutExtension();
I would remove this one. That does not seem like a very common operation to me
and it is easy to write:

new Path(p.directoryPath).append(p.filenameWithoutExtension)

I would be in favor of keeping the API small instead of adding methods for
things like this.

The same argument can be made for append:

p.append(final) could be written as p.join(new Path(final))

but that seems like a more common operation to me so I'm OK with that one.

[Bill Hesse, 2012-06-22 11:01:55]

https://chromiumcodereview.appspot.com/10638002/diff/3001/runtime/bin/path.dart
File runtime/bin/path.dart (right):

https://chromiumcodereview.appspot.com/10638002/diff/3001/runtime/bin/path.da...
runtime/bin/path.dart:173: String get pathWithoutExtension();
Agreed - append makes it easier to write this.

On 2012/06/22 07:41:41, Mads Ager wrote:
> I would remove this one. That does not seem like a very common operation to me
> and it is easy to write:
> 
> new Path(p.directoryPath).append(p.filenameWithoutExtension)
> 
> I would be in favor of keeping the API small instead of adding methods for
> things like this.
> 
> The same argument can be made for append:
> 
> p.append(final) could be written as p.join(new Path(final))
> 
> but that seems like a more common operation to me so I'm OK with that one.