Issue 10636045: Add a Pub source for pub.dartlang.org.

Issue 10636045: Add a Pub source for pub.dartlang.org. (Closed)

Created:
8 years, 6 months ago by nweiz

Modified:
8 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a Pub source for pub.dartlang.org. This fixes a race condition in commit 9094. Committed: https://code.google.com/p/dart/source/detail?r=9132

Patch Set 1 #

Total comments: 8

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+543 lines, -21 lines)			Patch
M	utils/pub/entrypoint.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/io.dart	View	4 chunks	+78 lines, -0 lines	0 comments	Download
M	utils/pub/pub.dart	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	utils/pub/pubspec.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
A	utils/pub/repo_source.dart	View	1 chunk	+106 lines, -0 lines	0 comments	Download
M	utils/pub/system_cache.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/pub/utils.dart	View	2 chunks	+25 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pub_test.dart	View	1 chunk	+106 lines, -0 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	12 chunks	+215 lines, -16 lines	8 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

The two changes here are to TarFileDescriptor#load, which now deletes the temp directory only after ...

8 years, 6 months ago (2012-06-26 01:18:45 UTC) #1

Bob Nystrom

Couple tiny nits. LGTM! https://chromiumcodereview.appspot.com/10636045/diff/1/utils/tests/pub/test_pub.dart File utils/tests/pub/test_pub.dart (right): https://chromiumcodereview.appspot.com/10636045/diff/1/utils/tests/pub/test_pub.dart#newcode243 utils/tests/pub/test_pub.dart:243: var subFuture = event(parentDir); "distantFuture"? ...

8 years, 6 months ago (2012-06-26 19:37:07 UTC) #2

nweiz

8 years, 6 months ago (2012-06-26 19:57:51 UTC) #3

https://chromiumcodereview.appspot.com/10636045/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10636045/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:243: var subFuture = event(parentDir);
On 2012/06/26 19:37:07, Bob Nystrom wrote:
> "distantFuture"? ;)

Cute, but I don't think that's clearer.

https://chromiumcodereview.appspot.com/10636045/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:524: class TarFileDescriptor extends Descriptor {
On 2012/06/26 19:37:07, Bob Nystrom wrote:
> This is really cool. :)

:)

https://chromiumcodereview.appspot.com/10636045/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:541: join(parentDir, name)];
On 2012/06/26 19:37:07, Bob Nystrom wrote:
> Indent another 2.

Done.

https://chromiumcodereview.appspot.com/10636045/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:547: "STDERR: ${Strings.join(result.stderr,
"\n")}";
On 2012/06/26 19:37:07, Bob Nystrom wrote:
> And here.

Done.

Expand Messages | Collapse Messages