Issue 10636035: Fix the normalization of test group names before use as DOM class or id names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10636035: Fix the normalization of test group names before use as DOM class or id names. (Closed)

Created:
8 years, 6 months ago by gram

Modified:
8 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix the normalization of test group names before use as DOM class or id names. See Issue 3855. Committed: https://code.google.com/p/dart/source/detail?r=9086

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	lib/unittest/html_enhanced_config.dart	View		1 chunk	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 6 months ago (2012-06-25 21:37:23 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10636035/diff/1/lib/unittest/html_enha...
File lib/unittest/html_enhanced_config.dart (right):

https://chromiumcodereview.appspot.com/10636035/diff/1/lib/unittest/html_enha...
lib/unittest/html_enhanced_config.dart:143: var safeGroup =
test_.currentGroup.replaceAll(nonAlphanumeric,'_');
add space after ','

Expand Messages | Collapse Messages