Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 10636003: Use JSON.printOn in SourceMapBuilder. (Closed)

Created:
8 years, 6 months ago by podivilov
Modified:
8 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use JSON.printOn in SourceMapBuilder. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=9100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M lib/compiler/implementation/source_map_builder.dart View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
podivilov
8 years, 6 months ago (2012-06-21 17:01:08 UTC) #1
ahe
8 years, 6 months ago (2012-06-21 19:49:23 UTC) #2
I don't like this you are forcing me to say "looks good to me" about something
which contains "JSON" ;-)

Well…

Hmm…

OK, then: LGTM

Powered by Google App Engine
This is Rietveld 408576698