Issue 10635020: Add new files and data structures for the new register allocator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10635020: Add new files and data structures for the new register allocator. (Closed)

Created:
8 years, 6 months ago by Florian Schneider

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add new files and data structures for the new register allocator. This CL adds new files to hold the new register allocator and adds a parallel-move instructions that will be used to insert moves for register constraints, spills and phi-resolution. No new functionality added yet. Committed: https://code.google.com/p/dart/source/detail?r=9027

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -5 lines)			Patch
M	vm/compiler.cc	View	3 chunks	+11 lines, -0 lines	0 comments	Download
A	vm/flow_graph_allocator.h	View	1 chunk	+28 lines, -0 lines	1 comment	Download
A	vm/flow_graph_allocator.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	vm/flow_graph_builder.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	vm/il_printer.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	vm/intermediate_language.h	View	4 chunks	+34 lines, -1 line	0 comments	Download
M	vm/intermediate_language.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	vm/vm_sources.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://chromiumcodereview.appspot.com/10635020/diff/1/vm/flow_graph_allocator.h File vm/flow_graph_allocator.h (right): https://chromiumcodereview.appspot.com/10635020/diff/1/vm/flow_graph_allocator.h#newcode11 vm/flow_graph_allocator.h:11: namespace dart { Maybe add a comment that this ...

8 years, 6 months ago (2012-06-22 14:10:20 UTC) #3

srdjan

8 years, 6 months ago (2012-06-22 14:10:36 UTC) #4

LGTM as well

On 2012/06/22 14:10:20, srdjan wrote:
>
https://chromiumcodereview.appspot.com/10635020/diff/1/vm/flow_graph_allocator.h
> File vm/flow_graph_allocator.h (right):
> 
>
https://chromiumcodereview.appspot.com/10635020/diff/1/vm/flow_graph_allocato...
> vm/flow_graph_allocator.h:11: namespace dart {
> Maybe add a comment that this is a register allocator, and say something about
> it.

Expand Messages | Collapse Messages