Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 10633006: Process all resolver treeshaked elements in Dart backend. (Closed)

Created:
8 years, 6 months ago by Anton Muhin
Modified:
8 years, 6 months ago
Reviewers:
ahe, Roman
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Process all resolver treeshaked elements in Dart backend. For now the processing is a simple unparse validation. Committed: https://code.google.com/p/dart/source/detail?r=9078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -102 lines) Patch
M lib/compiler/implementation/compiler.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M lib/compiler/implementation/dart_backend/backend.dart View 1 chunk +14 lines, -97 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anton Muhin
8 years, 6 months ago (2012-06-21 16:37:45 UTC) #1
ahe
Seems reasonable, seems kinda hack'ish to use codegen and assembleProgram like you do. Perhaps we ...
8 years, 6 months ago (2012-06-21 20:04:48 UTC) #2
Anton Muhin
Turning into a proper review now.
8 years, 6 months ago (2012-06-22 11:23:54 UTC) #3
ahe
8 years, 6 months ago (2012-06-25 15:25:48 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698