Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 10632020: First take on proper dart2dart testing (Closed)

Created:
8 years, 6 months ago by Anton Muhin
Modified:
8 years, 6 months ago
Reviewers:
ahe, Roman
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M tests/compiler/dart2js/unparser_test.dart View 1 4 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anton Muhin
8 years, 6 months ago (2012-06-22 15:07:43 UTC) #1
ahe
Approach is okay
8 years, 6 months ago (2012-06-25 15:28:53 UTC) #2
Anton Muhin
Turning into proper review
8 years, 6 months ago (2012-06-25 18:50:35 UTC) #3
ahe
8 years, 6 months ago (2012-06-25 21:18:58 UTC) #4
lgtm

Nit: do not put spaces after [, and  before ]

Powered by Google App Engine
This is Rietveld 408576698