Issue 10632010: Fix excessive deoptimizations in Meteor: kSHL on two Smi-s can easily overflow, which led to deopti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10632010: Fix excessive deoptimizations in Meteor: kSHL on two Smi-s can easily overflow, which led to deopti… (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix excessive deoptimizations in Meteor: kSHL on two Smi-s can easily overflow, which led to deoptimization. In case of overflow call the IC target directly in case instead of deoptimizing. Necessary only for IA32. Committed: https://code.google.com/p/dart/source/detail?r=9009

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -8 lines)			Patch
	M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3	5 chunks	+27 lines, -6 lines	0 comments	Download
	M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10632010/diff/1007/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10632010/diff/1007/runtime/vm/intermediate_language_ia32.cc#newcode1765 runtime/vm/intermediate_language_ia32.cc:1765: kDeoptUnaryOp, This is also wrong on the x64 ...

8 years, 6 months ago (2012-06-21 22:43:57 UTC) #2

srdjan

8 years, 6 months ago (2012-06-21 22:56:36 UTC) #3

https://chromiumcodereview.appspot.com/10632010/diff/1007/runtime/vm/intermed...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10632010/diff/1007/runtime/vm/intermed...
runtime/vm/intermediate_language_ia32.cc:1765: kDeoptUnaryOp,
On 2012/06/21 22:43:57, regis wrote:
> This is also wrong on the x64 side.

Done.

https://chromiumcodereview.appspot.com/10632010/diff/1007/runtime/vm/intermed...
runtime/vm/intermediate_language_ia32.cc:1818: kDeoptUnaryOp,
On 2012/06/21 22:43:57, regis wrote:
> This is also wrong on the x64 side.

Done.

Expand Messages | Collapse Messages