Implement JSON serialization to stream.

Implement JSON serialization to stream.


R=antonm@google.com,ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=8991

[Anton Muhin, 2012-06-21 11:02:19]

overall lgtm, let's discuss various details

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart#new...
lib/json/json.dart:39: static void dump(Object object, StringBuffer output) {
maybe make StringBuffer an optional argument of stringify.

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart#new...
lib/json/json.dart:410: static String stringify(final object) {
maybe we should drop this method altogether and move this logic into
JSON.stringify?

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart#new...
lib/json/json.dart:423: : _seen = new List<Object>() {}
nit: please, use _seen = []

[podivilov, 2012-06-21 11:44:16]

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart#new...
lib/json/json.dart:39: static void dump(Object object, StringBuffer output) {
On 2012/06/21 11:02:19, antonmuhin wrote:
> maybe make StringBuffer an optional argument of stringify.

I think these are just different functions, no need to merge them together. And
dump(obj, sb) shouldn't return a String.

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart#new...
lib/json/json.dart:410: static String stringify(final object) {
On 2012/06/21 11:02:19, antonmuhin wrote:
> maybe we should drop this method altogether and move this logic into
> JSON.stringify?

It might be a good idea, but I prefer to keep this change targeted.

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart#new...
lib/json/json.dart:423: : _seen = new List<Object>() {}
On 2012/06/21 11:02:19, antonmuhin wrote:
> nit: please, use _seen = []

Done.

[Anton Muhin, 2012-06-21 11:50:00]

lgtm

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart#new...
lib/json/json.dart:39: static void dump(Object object, StringBuffer output) {
Okay, than maybe rename it to printOn---there is an idea to drop toString
altogether and use printOn w/ very similar semantics.

On 2012/06/21 11:44:17, podivilov wrote:
> On 2012/06/21 11:02:19, antonmuhin wrote:
> > maybe make StringBuffer an optional argument of stringify.
> 
> I think these are just different functions, no need to merge them together.
And
> dump(obj, sb) shouldn't return a String.

[podivilov, 2012-06-21 12:03:58]

Thanks!

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10632002/diff/1/lib/json/json.dart#new...
lib/json/json.dart:39: static void dump(Object object, StringBuffer output) {
On 2012/06/21 11:50:00, antonmuhin wrote:
> Okay, than maybe rename it to printOn---there is an idea to drop toString
> altogether and use printOn w/ very similar semantics.
> 
> On 2012/06/21 11:44:17, podivilov wrote:
> > On 2012/06/21 11:02:19, antonmuhin wrote:
> > > maybe make StringBuffer an optional argument of stringify.
> > 
> > I think these are just different functions, no need to merge them together.
> And
> > dump(obj, sb) shouldn't return a String.
> 

Done.

[Søren Gjesse, 2012-06-25 07:46:38]

https://chromiumcodereview.appspot.com/10632002/diff/4/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10632002/diff/4/lib/json/json.dart#new...
lib/json/json.dart:37: * Serializes [:object:] into [:output:] stream.
DBC

Shouldn this be just [object] and [output] (without the :'s) when referring to
the arguments?

[podivilov, 2012-06-25 13:28:44]

https://chromiumcodereview.appspot.com/10632002/diff/4/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10632002/diff/4/lib/json/json.dart#new...
lib/json/json.dart:37: * Serializes [:object:] into [:output:] stream.
On 2012/06/25 07:46:38, Søren Gjesse wrote:
> DBC
> 
> Shouldn this be just [object] and [output] (without the :'s) when referring to
> the arguments?

grep showed that it probably should. Do you know if this syntax is documented
somewhere?

[ahe, 2012-06-25 13:30:22]

https://chromiumcodereview.appspot.com/10632002/diff/4/lib/json/json.dart
File lib/json/json.dart (right):

https://chromiumcodereview.appspot.com/10632002/diff/4/lib/json/json.dart#new...
lib/json/json.dart:37: * Serializes [:object:] into [:output:] stream.
On 2012/06/25 13:28:44, podivilov wrote:
> On 2012/06/25 07:46:38, Søren Gjesse wrote:
> > DBC
> > 
> > Shouldn this be just [object] and [output] (without the :'s) when referring
to
> > the arguments?
> 
> grep showed that it probably should. Do you know if this syntax is documented
> somewhere?

Sorry, Google-internal URL:

http://chromegw.corp.google.com/viewvc/dash/attic/guide/dartguide.xml#Comment...