Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 10629002: Avoid passing a null uri to translateUri. (Closed)

Created:
8 years, 6 months ago by Johnni Winther
Modified:
8 years, 5 months ago
Reviewers:
karlklose, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Avoid passing a null uri to translateUri. This happens when reportDiagnostic is called from readScript. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9150

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed to SourceSpan with non-null uri #

Patch Set 3 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/compiler/implementation/compiler.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnni Winther
8 years, 6 months ago (2012-06-21 09:27:45 UTC) #1
karlklose
LGTM.
8 years, 6 months ago (2012-06-21 09:36:30 UTC) #2
ahe
http://codereview.chromium.org/10629002/diff/1/lib/compiler/implementation/apiimpl.dart File lib/compiler/implementation/apiimpl.dart (right): http://codereview.chromium.org/10629002/diff/1/lib/compiler/implementation/apiimpl.dart#newcode99 lib/compiler/implementation/apiimpl.dart:99: if (span === null || span.uri === null) { ...
8 years, 6 months ago (2012-06-22 08:49:33 UTC) #3
Johnni Winther
http://codereview.chromium.org/10629002/diff/1/lib/compiler/implementation/apiimpl.dart File lib/compiler/implementation/apiimpl.dart (right): http://codereview.chromium.org/10629002/diff/1/lib/compiler/implementation/apiimpl.dart#newcode99 lib/compiler/implementation/apiimpl.dart:99: if (span === null || span.uri === null) { ...
8 years, 6 months ago (2012-06-22 11:40:55 UTC) #4
Johnni Winther
PTAL
8 years, 5 months ago (2012-06-26 10:39:23 UTC) #5
ahe
8 years, 5 months ago (2012-06-26 11:38:41 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698