Add a Pub source for pub.dartlang.org.

Add a Pub source for pub.dartlang.org.

Committed: https://code.google.com/p/dart/source/detail?r=9090

[Bob Nystrom, 2012-06-22 22:35:44]

A couple of minor suggestions.

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:281: return;
The return is unnecessary.

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:443: Uri _getUri(url) {
Mixing "uri" and "url" here is a bit confusing. Pick one and use it for both the
method and param?

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/repo_source....
File utils/pub/repo_source.dart (right):

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/repo_source....
utils/pub/repo_source.dart:26: * At time of writing, pub.dartlang.org is not yet
online, but it should be
I'd leave a TODO here to update this comment when it changes.

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/repo_source....
utils/pub/repo_source.dart:45: ["--extract", "--gunzip", "--directory",
destPath]);
How do you feel about wrapping this in a function in pub_io? It's going to need
some Windows-specific support at some point, and I'd like to keep the
platform-specific code in one place. I think other stuff that needs Windows love
(like symlink) is there now.

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/utils.dart
File utils/pub/utils.dart (right):

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/utils.dart#n...
utils/pub/utils.dart:88: var buf = new StringBuffer();
"buf" -> "buffer".

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/utils.dart#n...
utils/pub/utils.dart:89: var i = 0;
"i" -> "start"

[nweiz, 2012-06-25 22:25:17]

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:281: return;
On 2012/06/22 22:35:44, Bob Nystrom wrote:
> The return is unnecessary.

Done.

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:443: Uri _getUri(url) {
On 2012/06/22 22:35:44, Bob Nystrom wrote:
> Mixing "uri" and "url" here is a bit confusing. Pick one and use it for both
the
> method and param?

Done.

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/repo_source....
File utils/pub/repo_source.dart (right):

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/repo_source....
utils/pub/repo_source.dart:26: * At time of writing, pub.dartlang.org is not yet
online, but it should be
On 2012/06/22 22:35:44, Bob Nystrom wrote:
> I'd leave a TODO here to update this comment when it changes.

Done.

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/repo_source....
utils/pub/repo_source.dart:45: ["--extract", "--gunzip", "--directory",
destPath]);
On 2012/06/22 22:35:44, Bob Nystrom wrote:
> How do you feel about wrapping this in a function in pub_io? It's going to
need
> some Windows-specific support at some point, and I'd like to keep the
> platform-specific code in one place. I think other stuff that needs Windows
love
> (like symlink) is there now.

Done.

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/utils.dart
File utils/pub/utils.dart (right):

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/utils.dart#n...
utils/pub/utils.dart:88: var buf = new StringBuffer();
On 2012/06/22 22:35:44, Bob Nystrom wrote:
> "buf" -> "buffer".

Done.

https://chromiumcodereview.appspot.com/10628016/diff/1/utils/pub/utils.dart#n...
utils/pub/utils.dart:89: var i = 0;
On 2012/06/22 22:35:44, Bob Nystrom wrote:
> "i" -> "start"

Done.

[srdjan, 2012-06-25 23:18:05]

DBC

https://chromiumcodereview.appspot.com/10628016/diff/8001/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10628016/diff/8001/utils/pub/io.dart#n...
utils/pub/io.dart:462: return new Uri.fromString(ur);
Must pass uri