Issue 10627004: Listen for on.error events in test_controller.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10627004: Listen for on.error events in test_controller.js (Closed)

Created:
8 years, 6 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 6 months ago

Reviewers:
vsm, Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Listen for on.error events in test_controller.js Committed: https://code.google.com/p/dart/source/detail?r=8983

Patch Set 2 : addressing comments #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -30 lines)			Patch
	M	lib/unittest/test_controller.js	View	1	1 chunk	+35 lines, -5 lines	0 comments	Download
	M	tools/testing/dart/browser_test.dart	View		1 chunk	+0 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm w/ comment addressed https://chromiumcodereview.appspot.com/10627004/diff/1/lib/unittest/test_controller.js File lib/unittest/test_controller.js (right): https://chromiumcodereview.appspot.com/10627004/diff/1/lib/unittest/test_controller.js#newcode51 lib/unittest/test_controller.js:51: var element = document.createElement('pre'); It ...

8 years, 6 months ago (2012-06-21 14:39:48 UTC) #2

Siggi Cherem (dart-lang)

8 years, 6 months ago (2012-06-21 15:32:20 UTC) #3

https://chromiumcodereview.appspot.com/10627004/diff/1/lib/unittest/test_cont...
File lib/unittest/test_controller.js (right):

https://chromiumcodereview.appspot.com/10627004/diff/1/lib/unittest/test_cont...
lib/unittest/test_controller.js:51: var element = document.createElement('pre');
On 2012/06/21 14:39:48, antonmuhin wrote:
> It might be worth to refactor failure dealing code, cf. ln. 37--40.

Done.

Expand Messages | Collapse Messages

Issue 10627004: Listen for on.error events in test_controller.js (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressing comments #

Messages